Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python workers: Better error handling when the handler is not defined #3495

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Python workers: Better error handling when the handler is not defined #3495

merged 2 commits into from
Feb 7, 2025
+68 −2

Conversation

hoodmane
Copy link
Contributor

@hoodmane hoodmane commented Feb 7, 2025

No description provided.

@hoodmane hoodmane requested review from a team as code owners February 7, 2025 16:02
@hoodmane hoodmane requested review from npaun and a-robinson February 7, 2025 16:02
@hoodmane hoodmane force-pushed the hoodmane/undefined-handler branch from 3271d3e to be162fb Compare February 7, 2025 16:03
@hoodmane hoodmane changed the title Better error handling when the handler is not defined Python workers: Better error handling when the handler is not defined Feb 7, 2025
@hoodmane hoodmane added the python Issues/PRs relating to Python Workers label Feb 7, 2025
dom96
dom96 approved these changes Feb 7, 2025
View reviewed changes
Copy link
Collaborator

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there is some logic for this in the validator, so gotta make sure this doesn't impact that. Our internal tests should hopefully cover that.

src/workerd/server/tests/python/BUILD.bazel Outdated Show resolved Hide resolved
@dom96
Copy link
Collaborator

dom96 commented Feb 7, 2025

Actually looking at python-validation-test I don't see a test case for when on_fetch is missing, might be worth adding it as part of this change.

@hoodmane hoodmane merged commit b51f49e into main Feb 7, 2025
17 of 18 checks passed
@hoodmane hoodmane deleted the hoodmane/undefined-handler branch February 7, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

@npaun npaun Awaiting requested review from npaun npaun is a code owner automatically assigned from cloudflare/workers-runtime-1

@a-robinson a-robinson Awaiting requested review from a-robinson a-robinson is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
python Issues/PRs relating to Python Workers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @dom96