-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent exception when passing directory instead of file #3446
Open
jmorrell-cloudflare
wants to merge
2
commits into
main
Choose a base branch
from
jmorrell/fix-segfault-on-directory
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+6
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmorrell-cloudflare
changed the title
Prevent uncaught exception when passing directory instead of file
Prevent exception when passing directory instead of file
Jan 31, 2025
All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
The generated output of |
kentonv
approved these changes
Jan 31, 2025
Hmm, the code looks right to me but CI suggests it is not, somehow. |
Not sure I understand what's going on here, perhaps a rebase will solve it? 🤔 |
kentonv
reviewed
Feb 3, 2025
…fault when its a directory
jmorrell-cloudflare
force-pushed
the
jmorrell/fix-segfault-on-directory
branch
from
February 3, 2025 18:31
234d182
to
8377a11
Compare
jmorrell-cloudflare
force-pushed
the
jmorrell/fix-segfault-on-directory
branch
from
February 7, 2025 20:37
aed936d
to
82c60e3
Compare
kentonv
approved these changes
Feb 7, 2025
danlapid
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you accidentally pass a directory path instead of a capnp config file to
workerd serve $path
you get an uncaught exception:This change adds an assertion that the provided path is a file type. Invoking
workerd serve
with a directory now results in the following error: