Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in Workers example #4884

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

irvinebroque
Copy link

Seems like examples here aren't autogen

Copy link
Contributor

Oops! It looks like no changelog entry is attached to this PR. Please include a release note as described in https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/contributing/changelog-process.md.

Example:

```release-note:TYPE
Release note
```

If you do not require a release note to be included and you have permission, please add the workflow/skip-changelog-entry label. Otherwise, a maintainer will add the label or ask you for one when they review the PR.

@jacobbednarz
Copy link
Member

yep, v4.x does not have autogenerated examples. 5.x onwards is.

two things with this:

  1. this is the legacy resource (worker_script, missing the s in workers) and it's around for documentation purposes if folks are still using it.
  2. if we don't want this, we need to update https://github.com/cloudflare/terraform-provider-cloudflare/blob/master/examples/resources/cloudflare_worker_script/resource.tf as the docs directory is generated from the schema + examples to build these pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants