tokio-quiche: preserve raw socket capabilities - #2588
Open
idy wants to merge 1 commit into
Open
Conversation
Raw QUIC connections discarded the capabilities detected for their UDP socket, forcing the writer to disable GSO, pacing offload, and packet info. - Build the raw writer configuration from the supplied socket capabilities - Select IPv4 or IPv6 packet info according to the local address family - Add coverage for GSO, pacing offload, and packet-info propagation Generated with [Codex](https://github.com/openai)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the UDP socket capabilities supplied to
wrap_quiche_conn()whenconstructing the raw connection writer.
The raw wrapper currently hardcodes GSO, pacing offload, and packet-info
support to
false, even thoughSocket<Tx, Rx>already carries the detectedSocketCapabilities. As a result, callers that manually feed receivedpackets into a raw QUIC connection cannot use send offloads supported by the
underlying socket.
This change:
has_gso;has_txtime;The default capability values remain disabled, so callers that do not detect
or provide these capabilities retain the existing behavior.
Testing
cargo +nightly fmt -- --checkcargo test -p tokio-quiche raw_writer_preserves_socket_send_capabilitiescargo clippy -p tokio-quiche --all-targets -- -D warnings