Move ai-gateway-provider to cloudflare/ai repo #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G4brym
changed the title
G4brym
force-pushed
the
move-ai-gateway-provider
branch
from
b7212c0 to
7674c4a
Compare
G4brym
force-pushed
the
move-ai-gateway-provider
branch
from
7674c4a to
2875ca9
Compare
|
This looks good! The only change I would suggest is to add some tests. You could use a similar pattern to what we have here whereby the AI remote call is mocked. |
andyjessop
reviewed
Apr 1, 2025
| request?: { body?: string }; | ||
| warnings?: Array<LanguageModelV1CallWarning>; | ||
| }> { | ||
| throw new Error("Method not implemented."); |
There was a problem hiding this comment.
Do we have plans to implement this? Streaming output seems to be more common, so I think that we will have lots of requests for this.
There was a problem hiding this comment.
its on my todo list, i will get to that next week or after devweek
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.