New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix proxy-authentication headers for Python 3.* and long basic credential encodings #562

Open

paulmayer wants to merge 4 commits into cloudera:master from paulmayer:bugfix/invalid-long-basic-auth-credential-encoding

+75 −10

paulmayer commented Feb 2, 2025

Added tests that cover the descriptions of PLAIN auth with http transport fails producing valid BASIC auth header for long username/password combinations #540 and 🐛 Bug in proxy setting #517
Changed plain/ldap auth and proxy authentication to use the same utility function to encode credentials

Fixes #540
Fixes #517

Note:

Tested with 2.7 and 3.7+
Tried to use module-local conventions (e.g. unittest/pytest)
I'm using impala quickstarter for local test execution, no hive tests executed
impala.tests.test_dbapi_connect.ImpalaConnectionTests.test_retry_dml generally fails for me (and failed also before making any modifcations)

Paul Mayer added 4 commits

February 2, 2025 17:37


          add failing tests for basic auth and proxy auth

d409c63


          add basic credential encoding utility function

ec02ff0


          fix proxy-auth header generation and long basic credential encoding

8817abd


          remove prints

157c843

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet