[ui-storagebrowser] add useWindowSize hook to get window size #3930
+224
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohanAhlen
reviewed
Jan 6, 2025
bjornalm
requested changes
Feb 3, 2025
| useLayoutEffect(() => { | ||
| handleResize(); | ||
|
|
||
| window.addEventListener('resize', handleResize); |
There was a problem hiding this comment.
Please use the ResizeObserver API instead of window so that this code is triggered if parent containers get resized without and actual resize of the window.
I think this is a limitation of the underlying antd table, at least I had the same issue when creating the infinite scroll table. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?