Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Halt github api throttling #34

Merged
merged 1 commit into from
Dec 26, 2024
Merged

Halt github api throttling #34

merged 1 commit into from
Dec 26, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Dec 26, 2024

Changes proposed in this pull request:

  • Tired of getting:

error running command: GET https://api.github.com/repos/cloudfoundry/app-autoscaler-release/releases/assets/198385215: 403 API rate limit exceeded for x.x.x.x. (But here's the good news: Authenticated requests get a higher rate limit. Check out the documentation for more details.) [rate reset in 23m17s]

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None that I can think of, the check would use an authenticated token to hopefully not get throttled, the repo itself is not owned by Cloud.gov

@cweibel cweibel requested a review from a team as a code owner December 26, 2024 16:08
Copy link

@spgreenberg spgreenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cweibel cweibel merged commit f2d524a into main Dec 26, 2024
1 check passed
@cweibel cweibel deleted the gh_token branch December 26, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants