Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off staging after hours #31

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Turn off staging after hours #31

merged 1 commit into from
Jul 11, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Jul 11, 2024

Changes proposed in this pull request:

  • This is a similar change as the previous PR, it adds a timer and job that turns staging off after 6PM PT.
  • A stemcell update, release update or changes to the pipeline will trigger the environment to turn back on, this is a desired behavior. If needed, can add a "turn on" timer that triggers the "deploy-" which will redeploy the environment
  • Save more $$$ on EC2 costs. As long as the RDS db that backs the deployment is left alone, the deployment can remain turned off indefinitely but no scaling events will occur.

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@cweibel cweibel requested a review from a team as a code owner July 11, 2024 12:24
@cweibel cweibel merged commit fabd839 into main Jul 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants