Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy and delete should not happen at the same time #29

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Deploy and delete should not happen at the same time #29

merged 1 commit into from
Jul 9, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented Jul 9, 2024

Changes proposed in this pull request:

  • Deploy and delete should not happen at the same time, don't upset bosh

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@cweibel cweibel requested a review from a team as a code owner July 9, 2024 16:29
@cweibel cweibel merged commit b799283 into main Jul 9, 2024
1 check passed
@cweibel cweibel deleted the serial-dev branch July 9, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisMcGowan ChrisMcGowan ChrisMcGowan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cweibel @ChrisMcGowan