Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Longer names for pipelines #23

Merged
merged 1 commit into from
May 20, 2024
Merged

Longer names for pipelines #23

merged 1 commit into from
May 20, 2024

Conversation

cweibel
Copy link
Contributor

@cweibel cweibel commented May 20, 2024

Changes proposed in this pull request:

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@cweibel cweibel requested a review from a team May 20, 2024 14:10
Copy link

@JasonTheMain JasonTheMain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Names, Not New liking. Good job Chris

@cweibel cweibel merged commit fe1baa6 into main May 20, 2024
1 check passed
@cweibel cweibel deleted the as0520 branch May 20, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants