Fix wrong mci selection in mouse right-click menu #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seokho Son <[email protected]>
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where the wrong MCI (Multi-Cloud Infrastructure) was being selected when using the right-click context menu on the map. The fix introduces a state management mechanism to prioritize context menu selections over dropdown selections.
Key Changes:
- Introduced a
contextMenuSelectedMcivariable andgetSelectedMciId()helper function to track and prioritize context menu selections - Removed event dispatches from the context menu setup to avoid race conditions with
updateMciList - Updated 9 functions to use
getSelectedMciId()instead of direct element access
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.