Loopback ip resolve issue #2
Conversation
|
Kai,
I'm just now working on new release for most of the libraries I maintain.
Your changes seem reasonable.
However, due to the policy established by the Clojure team, PRs are not
accepted on official Clojure projects, of which clr.core.cli.
The general mechanism is patches, so I could use the patches.
However, also due to policy, I cannot accept code from someone unless they
have signed a contributor agreement with Clojure.
Available here: Clojure - Contributor Agreement
<https://clojure.org/dev/contributor_agreement>
If you do that, I can pull in your patches and get them in the next release.
…-David
On Sun, Apr 21, 2024 at 4:59 AM Kai Zheng ***@***.***> wrote:
when calling start-server! function using default 127.0.0.1 , I don't get
a server with 127.0.0.1 but another ipv6. After I read the code, I found
that the Dns/GetHostEntr can't resolve 127.0.0.1 correctly but can handle
"localhost". another issue is about IPv4 and IPv6.
------------------------------
You can view, comment on, or merge this pull request online at:
#2
Commit Summary
- 05fee6d
<05fee6d>
[format] format code
- 0406c30
<0406c30>
[fixed] resolve 127.0.0.1 correctly
File Changes
(1 file <https://github.com/clojure/clr.tools.nrepl/pull/2/files>)
- *M* src/main/clojure/clojure/tools/nrepl.cljr
<https://github.com/clojure/clr.tools.nrepl/pull/2/files#diff-ff268a5247887b32aecd01de25c6c7a08194050e962eb4a5518f14c581c93457>
(17)
Patch Links:
- https://github.com/clojure/clr.tools.nrepl/pull/2.patch
- https://github.com/clojure/clr.tools.nrepl/pull/2.diff
—
Reply to this email directly, view it on GitHub
<#2>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAUVZNP5YZ7VWRWTXR7V23Y6N5X5AVCNFSM6AAAAABGRGRZ6CVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2TIOJXGU4DAOA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
dmiller, I want to give you the permission to the use of the code and do whatever you want to do. |
|
@Moriaty0o0 You have to sign the Contributor Agreement. None of us can take your code and include it in Clojure or Contrib without the signed CA on file. |
when calling start-server! function using default 127.0.0.1 , I don't get a server with 127.0.0.1 but another ipv6. After I read the code, I found that the Dns/GetHostEntr can't resolve 127.0.0.1 correctly but can handle "localhost". another issue is about IPv4 and IPv6.