Skip to content

Bump cider-nrepl to 0.56.0 #3824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

Bump cider-nrepl to 0.56.0 #3824

merged 3 commits into from
May 29, 2025

Conversation

alexander-yakushev
Copy link
Member

Together with upgrading the version, I've also spliced some redundant functions insider cider-inspector.el.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps cider‐nrepl to 0.56.0, updates version strings for dependency injection throughout tests, documentation, and project files, and removes redundant functions in cider‑inspector.el.

  • Updated version numbers in tests, docs, and project configuration to reflect the latest release.
  • Removed duplicated cider‑sync‑request wrappers in cider‑inspector.el to streamline nREPL interactions.
  • Updated CHANGELOG to document the changes and related issues.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
test/cider-tests.el Updated expected dependency versions in test assertions.
doc/modules/ROOT/pages/* Bumped version references in documentation for cider‑nrepl.
dev//.clj Updated project files to use the new cider‑nrepl version.
cider.el Updated required middleware version constant.
cider-inspector.el Removed redundant functions and revised nREPL call patterns.
CHANGELOG.md Documented the version bump and additional improvements.
Comments suppressed due to low confidence (2)

cider-inspector.el:425

  • The removal of the cider-sync-request:* functions is intended to reduce redundancy; ensure that any external code previously relying on these functions is updated to call cider-nrepl-send-sync-request directly.
;; nREPL interactions

test/cider-tests.el:146

  • Verify that the updated version strings used in tests are consistent with the actual dependency versions throughout the codebase and documentation to avoid potential mismatches.
(setq-local cider-injected-nrepl-version "1.2.3")

@bbatsov bbatsov merged commit 187a7e8 into master May 29, 2025
16 checks passed
@bbatsov
Copy link
Member

bbatsov commented May 29, 2025

For the version upgrades - for a long time I was thinking of adding a lein task or a Ruby script to do this (and updating the version when cutting a release), but I was too lazy to do it. And I guess I still am! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants