Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle negative line numbers in error messages #3688

Merged
merged 7 commits into from
May 29, 2024

Conversation

yuhan0
Copy link
Contributor

@yuhan0 yuhan0 commented May 29, 2024

(partially fixes) #3687
I took the opportunity to refactor some of the rx forms and add documentation, let me know if these should be separated out or squashed.


Before submitting the PR make sure the following things have been done (and denote this
by checking the relevant checkboxes):

  • The commits are consistent with our contribution guidelines
  • You've added tests (if possible) to cover your change(s)
  • All tests are passing (eldev test)
  • All code passes the linter (eldev lint) which is based on elisp-lint and includes
  • You've updated the changelog (if adding/changing user-visible functionality)
  • You've updated the user manual (if adding/changing user-visible functionality)

Thanks!

If you're just starting out to hack on CIDER you might find this section of its
manual
extremely useful.

@vemv
Copy link
Member

vemv commented May 29, 2024

LGTM - great work!

Did you check that there's coverage for all code paths in

1378a72 de162d5

?

@yuhan0
Copy link
Contributor Author

yuhan0 commented May 29, 2024

Yup, the existing cider-clojure-runtime-error-regexp tests cover both those cases:

Execution error (ArithmeticException) at foo/foo (src/haystack/parser.cljc:4).
where either (ArithmeticException) or foo/foo may be missing

@vemv vemv merged commit 8d67a14 into clojure-emacs:master May 29, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants