Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless bit of code from cheatsheet #3680

Merged
merged 1 commit into from
May 25, 2024
Merged

Remove useless bit of code from cheatsheet #3680

merged 1 commit into from
May 25, 2024

Conversation

katomuso
Copy link
Contributor

When the time comes to select var in cheatsheet, we first remove var lists with :url as the first element. However, there are no such var lists anymore.

This bit of code comes from the initial implementation, where lists with :url existed (though they served no purpose) and were later removed (bfdd79c).

Since this code doesn't serve any purpose anymore, we can easily remove it. In fact, we can remove the entire cider-cheatsheet--select-var function and replace its call, as it feels redundant, if you think that would be appropriate.

@bbatsov bbatsov merged commit fd95507 into clojure-emacs:master May 25, 2024
38 of 39 checks passed
@bbatsov
Copy link
Member

bbatsov commented May 25, 2024

Since this code doesn't serve any purpose anymore, we can easily remove it. In fact, we can remove the entire cider-cheatsheet--select-var function and replace its call, as it feels redundant, if you think that would be appropriate.

I guess you'll tweak the code further anyways, if you decide to re-order the selection logic. Thanks for giving the cheatsheet some love!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants