Skip to content

Tweak PR-writing guidance for agents - #6657

Merged
bfops merged 18 commits into
masterfrom
bfops/pr-authoring-guidance
Nov 21, 2026
Merged

bfops merged 18 commits into
masterfrom
bfops/pr-authoring-guidance

Conversation

@bfops

@bfops bfops commented Nov 20, 2026 •

Copy link
Copy Markdown
Collaborator

Description of Changes

Tweaked the guidance for agent-written PRs, and moved it into its own skill. Also added golden examples to hopefully minimize regressions as we iterate on the skill more.

API and ABI breaking changes

None.

Rollback safety impact

n/a

Expected complexity level and risk

1

Testing

Tested the skill on regression-test PRs, failed tests, untested changes, and edits to existing descriptions. Blind trials withheld the golden examples. Drafts still sometimes included individual assertions.

Original draft and reviewer-edited target for #6629

--- Before
+++ Editorial target
@@ -1,8 +1,10 @@
 # Testing
 
-All 85 client API library tests passed with default features disabled. The new tests exercise the HTTP route with a mock backend. Live Cloud hierarchy behavior remains untested.
-
-- Create and update requests forward the expected parent to publication when `parent` is omitted, supplied by name, or supplied as a hex identity. Creation authorization receives the same parent, including when `clear=true` targets a missing database.
-- An unknown parent name returns 404 before backend publication for both creates and updates.
-- Resetting an existing database with either form of `parent` returns 400 and skips the backend reset, even with reset permission. Temporarily removing the parent guard made this test fail with 200.
-- Without `parent`, a denied reset returns 403 and skips the backend reset. An authorized reset calls the backend once and reports the existing database as updated.
+Added four HTTP route tests covering the following behaviors:
+
+- Publishing to an existing database with `clear=true` and a parent (supplied by name or identity). Removing the guard correctly failed the test.
+- Clearing an existing database with no parent requires reset permission
+- Create and update requests use the requested parent. The same test covers:
+  - Creation checks permission for the requested parent.
+  - Publishing with `clear=true` creates the database if it does not exist.
+- An unknown parent name returns 404 for both creation and update

The target incorporates reviewer feedback. The golden examples retain the original agent-to-agent comparison.

@bfops bfops changed the title Turn PR-writing guidance into a skill with golden examples Tweak PR-writing guidance for agents Nov 20, 2026
@bfops
bfops added this pull request to the merge queue Nov 21, 2026
Merged via the queue into master with commit c0f3122 Nov 21, 2026
74 of 75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants