Add wasm32 support to the rust sdk #2704
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Using my fork of `tokio-tungstenite-wasm` due to the addition of the function `connect_with_protocols`. - `DbConnectionBuilder::build` becomes async without tokio's block_in_place. Still need to add `web` feature flag.
Replaces the unmaintained `anymap` dependency to fix a panic caused by `copy_nonoverlapping::precondition_check` due to alignment in `<TypeIdHasher as Hasher>::write` specific to web (wasm32) debug builds. The updated `anymap` fork drops its custom `Any` in favor of the standard library's `std::any::Any`.
|
|
Renamed the `run_threaded` method on `wasm32` to better reflect its behavior of spawning a background task. The generated `DbConnection` methods `run_threaded`, `run_background`, and `advance_one_message_blocking` now include runtime panics with a clear error feedback when called on unsupported targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Enabled the Rust SDK
wasm32compilation target for web usage.wasm32-unknown-unknownmust set:RUSTFLAGS='--cfg getrandom_backend="wasm_js"'to enable getrandom's webassembly support.webfeature flag, incompatible with non-wasm32targets.API and ABI breaking changes
None. Most changes apply only to the
wasm32target, so there are no global breaking changes. The main differences to the native targets are:DBConnectionBuilder::buildis nowasyncon the web.Filestruct unavailable on the web.gloo_storagefor local/session storage.HttpOnlycookies).Expected complexity level and risk
Estimated at 2:
Opening this PR as a draft to get comments on it.
Testing
I built 2 demos to exercise the changes: