Avoid reflection when constructing row in bsatn deserialization #2677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshua-spacetime
changed the title
joshua-spacetime
force-pushed
the
joshua/perf/avoid-reflection-in-row-decoding
branch
from
036680e to
2a49ec8
Compare
joshua-spacetime
changed the title
joshua-spacetime
changed the base branch from
joshua/perf/csharp-enum-validation
to
master
joshua-spacetime
changed the base branch from
master
to
joshua/perf/csharp-enum-validation
joshua-spacetime
force-pushed
the
joshua/perf/avoid-reflection-in-row-decoding
branch
from
2a49ec8 to
c62b26a
Compare
joshua-spacetime
force-pushed
the
joshua/perf/avoid-reflection-in-row-decoding
branch
from
c62b26a to
4fba3c2
Compare
|
I'd like to check if this actually monomorphizes in Unity |
|
|
bfops
added
release-any
|
From deep profiling Blackholio, this does not seem to result in monomorphization. I found https://andrewlock.net/benchmarking-4-reflection-methods-for-calling-a-constructor-in-dotnet/ which shows that activator.createinstance is still quite fast -- 40ns, versus 10ns for |
joshua-spacetime
force-pushed
the
joshua/perf/avoid-reflection-in-row-decoding
branch
from
4fba3c2 to
85be484
Compare
|
A bot test showed no improvement. Closing this in favor of the following codegen approach #2725. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Avoids paying
new T()'s (potential) cost of reflection on each row decode.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing