feat!: change TraceWith trait bounds to be on the field types and not on generics when deriving Trace#82
Open
bluurryy wants to merge 2 commits intoclaytonwramsey:masterfrom
Open
Conversation
Owner
|
Thanks! I think this is a good idea. I'll shelve this PR for a little while as I wait to bundle more breaking changes (e.g. #81) but will merge soon. |
…ot on generics when deriving `Trace`
da4d332 to
12b0d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: This is a breaking change!
Currently deriving
Traceon a struct like......expands to...
Here there is a trait bound on the generic parameter
Teven though both the fields implementTraceWithregardless ofT. We should only care that the field types implementTraceWith, notT, so thatGenericStructimplementsTraceeven ifTdoesn't.To implement this I've added a new dependency
synstructurethat delegates to the fields and collects trait bounds. I think it's worth adding this dependency because it massively simplifies the code and would allow easily adding field attributes in the future (like atrace(ignore)(I'd send a PR if this is merged)).With this PR the derive macro expands to...