Add failing test for fields_for validation #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Form builder methods called within a fields_for block generate NoMethodError by calling fetch on nil when rendering validation error messages from the associated object. This includes a failing test demonstrating the bug, not the fix itself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form builder methods called within
a fields_for block generate NoMethodError
by calling fetch on nil when rendering
validation error messages from the
associated object. This PR includes
a failing test demonstrating the bug, not
the fix itself.
The actual fix was previously submitted by @MichaelSp in PR #146, but since that has been open for a while, I'm hoping contributing a test will help move it along.