This repository was archived by the owner on May 27, 2020. It is now read-only.
Open
Conversation
|
FYI anything inside |
|
I had to ifdef the timing code for that driver since a bisect revealed the newer changes(the timing code not inside |
fb525da to
822d0f0
Compare
The prototypes for `cgsleep_ms_r` and `cgsleep_us_r` didn't match the implementation, and have been updated accordingly.
822d0f0 to
05a6340
Compare
Author
|
@jameshilliard I don't quite understand why the function signatures need to be different. It doesn't make much difference to me in either case. |
|
Yeah, it may not have been the function signatures that was the issue, I'll try and test these changes when I get some time to verify they don't introduce a regression there. |
|
This is also an issue for Windows cross compile. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The prototypes for
cgsleep_ms_randcgsleep_us_rdidn't match theimplementation, and have been updated accordingly.
There's something weird about these functions returning a value, since most of them were void but a couple were returning ints. My guess is that someone needed to debug something and added the code, but never updated the other functions. For the sake of backward compatibility I just added
return 0to the versions returning void.