Add table cell type support (CKEditor v47.x) #19445
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 26, 2025
…ad` if previous row was not header row.
Fix incorrect move of table row containing only `th` elements to `thead` if previous row was not header row (v47.x)
niegowski
reviewed
Dec 1, 2025
| } | ||
|
|
||
| const { rows, headingRows, headingColumns } = scanTable( viewTable ); | ||
| const { rows, headingRows, headingColumns } = scanTable( viewTable, ignoreHeaderRowMoveIfNormalRowsBefore ); |
Contributor
There was a problem hiding this comment.
I'd consider this a fix, not a breaking change, so the experimental flag is not needed here.
packages/ckeditor5-table/src/tablecellproperties/commands/tablecelltypecommand.ts
Show resolved
Hide resolved
packages/ckeditor5-table/src/tablecellproperties/commands/tablecelltypecommand.ts
Show resolved
Hide resolved
| * @param writer The model writer. | ||
| * @param tableUtils The table utils plugin instance. | ||
| */ | ||
| function adjustHeadingAttributesWhenChangingToHeader( |
Contributor
There was a problem hiding this comment.
Those helpers could be shared with the post-fixer. In reaction to cell types changes it modifies table attribute.
Update of the Table cell properties form UI.
…elltype Move table cell type setting logic to `TableUtils`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Summary
Feature branch that targets
47.xversion of the editor. Do not merge.PR for
v48version: #19446 (diff)Based on PoC: #19375
IMPORTANT: This PR should be merged to
masterbranch that targetsv47version of the editor.📌 Related issues
thsupport) #16730