Skip to content

[Vue] Pass DOM Element in the config object instead of editor constructor in CKEditor >= 48#403

Open
Mati365 wants to merge 8 commits intomasterfrom
ck/400
Open

[Vue] Pass DOM Element in the config object instead of editor constructor in CKEditor >= 48#403
Mati365 wants to merge 8 commits intomasterfrom
ck/400

Conversation

@Mati365
Copy link
Copy Markdown
Member

@Mati365 Mati365 commented Mar 30, 2026

🚀 Summary

[Vue] Pass DOM Element in the config object instead of editor constructor in CKEditor >= 48


📌 Related issues

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

There are 3 total unresolved issues (including 2 from previous reviews).

Autofix Details

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Falsy || operator mishandles empty string initial data
    • Replaced || with ?? in the initial data fallback chain so empty string values are preserved instead of incorrectly falling through.

Create PR

Or push these changes by commenting:

@cursor push 79fe15d4fc
Preview (79fe15d4fc)
diff --git a/src/compatibility/getInitialDataFromEditorConfig.ts b/src/compatibility/getInitialDataFromEditorConfig.ts
--- a/src/compatibility/getInitialDataFromEditorConfig.ts
+++ b/src/compatibility/getInitialDataFromEditorConfig.ts
@@ -14,7 +14,7 @@
 	const supports = getInstalledCKBaseFeatures();
 
 	if ( supports.rootsConfigEntry ) {
-		return config.roots?.main?.initialData || config.root?.initialData || /* legacy */ config.initialData;
+		return config.roots?.main?.initialData ?? config.root?.initialData ?? /* legacy */ config.initialData;
 	}
 
 	return config.initialData;

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

@Mati365 Mati365 changed the title Improve support of CKEditor 48.x [Vue] Pass DOM Element in the config object instead of editor constructor in CKEditor >= 48 Mar 30, 2026
@Mati365 Mati365 requested a review from gorzelinski April 1, 2026 12:09
@ckeditor ckeditor deleted a comment from cursor bot Apr 1, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Vue] Pass DOM Element in the config object instead of editor constructor in CKEditor >= 48

1 participant