Add support for the Watchdog features#217
Add support for the Watchdog features#217jeffnorris1 wants to merge 39 commits intockeditor:masterfrom
Conversation
|
Jaw drop :) That's a massive contribution 👏 Thank you! |
|
@psmyrek, would you like to review these changes? |
|
Hey @jnorris-cs! This is awesome, thank you for your contribution. Before merging this PR we would need also the |
@psmyrek I dont have the time to work on the |
|
Any news regarding ContextWatchdog support?
|
Feature: The component contains the built-in watchdog feature. Address #4694
Feature: The onError() callback will be called with two arguments. The first one will be an error object (as it was before the release 3+). A second argument is an object that contains two properties:
{String} phase: 'initialization'|'runtime' - Informs when the error has occurred (during the editor/context initialization or after the initialization).
{Boolean} willEditorRestart - When true, it means that the editor component will restart itself.
The willEditorRestart property will not appear when the error has occurred in the context feature.
Additional information
I did not add support for the
Context watchdoglike the React adapter has. I need to understandContext watchdogbetter to support it.I basically copied the changes to the react adapter to the vue adapter.
I bumped the major version of the adapter since react went from 2.x to 3.0 with same change.
I tried to follow the PR conventions as best as I understand them. Please let me know if I missed anything.
All the watchdog feature request in the project were closed as duplicates in favor of ckeditor/ckeditor5#4693 so that is why I linked an issue in a different project.