Add pagination and PEP-8 improvements.

[LondonAppDev]

I have added pagination which is enabled by adding the 'paginate_by' key to the info dict of the report. Also a number of small changes for PEP-8 compliance. Documentation has been updated to include information for enabling pagination.

[davidread]

Thanks for this idea. We have occasionally had problems with reports which are 100s of screenfuls long - they take way too long to render, take up lots of memory, and in these cases pagination would be great.

However I'm a big fan of navigating a report by scrolling down, searching a report by doing Ctrl-F, printing a report using Ctrl-P and saving it with Ctrl-S, none of which you can do when pagination is used. So for reports that have pagination configured, what do you think about it automatically showing an option to turn off pagination?

[LondonAppDev]

Hi David,

Thanks for getting back to me on the pull request.

Yes, I totally agree. I myself, am a fan of using Ctrl+F to find items in a
report and I think adding an option to turn off pagination is a great idea.

I'm currently travelling until Jan 2016 and won't get a chance to add this
before then. In the changes I made in this pull request, the pagination is
disabled by default and only enabled on reports which specify the
'paginate_by' setting. I'm wondering if you would be happy to merge this
request for now and then I'll add the option later on?

Cheers,
Mark

*Mark Winterbottom | *Full-Stack Software Engineer
Mobile: +44 (0) 7918 713 807
Website: http://mark.winterbottom.me
LinkedIn: https://www.linkedin.com/in/markwinterbottom
Blog: http://londonappdeveloper.com

On Wed, Dec 9, 2015 at 1:01 PM, David Read [email protected] wrote:

Thanks for this idea. We have occasionally had problems with reports which
are 100s of screenfuls long - they take way too long to render, take up
lots of memory, and in these cases pagination would be great.

However I'm a big fan of navigating a report by scrolling down, searching
a report by doing Ctrl-F, printing a report using Ctrl-P and saving it with
Ctrl-S, none of which you can do when pagination is used. So for reports
that have pagination configured, what do you think about it automatically
showing an option to turn off pagination?

—
Reply to this email directly or view it on GitHub
#11 (comment)
.

[davidread]

Cool that you agree about this extra bit. I'd prefer to just hold off
merging until it can be switched turned off, if that's ok, as I think it is
essential to this feature.

On 11 December 2015 at 15:05, Mark Winterbottom [email protected]
wrote:

Hi David,

Thanks for getting back to me on the pull request.

Yes, I totally agree. I myself, am a fan of using Ctrl+F to find items in a
report and I think adding an option to turn off pagination is a great idea.

I'm currently travelling until Jan 2016 and won't get a chance to add this
before then. In the changes I made in this pull request, the pagination is
disabled by default and only enabled on reports which specify the
'paginate_by' setting. I'm wondering if you would be happy to merge this
request for now and then I'll add the option later on?

Cheers,
Mark

*Mark Winterbottom | *Full-Stack Software Engineer
Mobile: +44 (0) 7918 713 807
Website: http://mark.winterbottom.me
LinkedIn: https://www.linkedin.com/in/markwinterbottom
Blog: http://londonappdeveloper.com

On Wed, Dec 9, 2015 at 1:01 PM, David Read [email protected]
wrote:

Thanks for this idea. We have occasionally had problems with reports
which
are 100s of screenfuls long - they take way too long to render, take up
lots of memory, and in these cases pagination would be great.

However I'm a big fan of navigating a report by scrolling down, searching
a report by doing Ctrl-F, printing a report using Ctrl-P and saving it
with
Ctrl-S, none of which you can do when pagination is used. So for reports
that have pagination configured, what do you think about it automatically
showing an option to turn off pagination?

—
Reply to this email directly or view it on GitHub
<
#11 (comment)

.

—
Reply to this email directly or view it on GitHub
#11 (comment)
.