Instance Snapshots #240
Draft
Instance Snapshots #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces instance snapshot functionality with corresponding tests and fake client implementations for easier automated testing.
- Adds API methods for creating, retrieving, listing, updating, and deleting instance snapshots
- Provides comprehensive tests to verify each snapshot operation
- Implements fake client support to simulate instance snapshot behavior in tests
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| instance_snapshot_test.go | Contains tests for snapshot operations (create, get, list, update, delete) |
| instance_snapshot.go | Implements core instance snapshot functions and endpoints |
| fake_client.go | Provides fake client implementations for snapshot operations |
Comments suppressed due to low confidence (1)
fake_client.go:2026
- The 'InstanceSnapshots' type is defined but never used; consider removing it to maintain clarity in the codebase.
// InstanceSnapshots represents a list of instance snapshots in the fake client
giornetta
reviewed
Apr 2, 2025
| @@ -2022,3 +2022,121 @@ func (c *FakeClient) UnassignIP(id, region string) (*SimpleResponse, error) { | |||
| Result: "success", | |||
| }, nil | |||
| } | |||
|
|
|||
| // InstanceSnapshots represents a list of instance snapshots in the fake client | |||
| type InstanceSnapshots struct { | |||
There was a problem hiding this comment.
Why is this plural?
It doesn't look like a list of instance snapshots.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.