Conversation
dianamartin
left a comment
There was a problem hiding this comment.
Does the footer stay at the bottom of the page?
The Footer will load or persist under existing body/content and in most cases will appear at the bottom of the page. It wont appear at the absolute bottom of a browser window. There is a potential scenario that any content that is purposely loaded after it, would appear below it, which is not likely since we dont surface ads or the like to our users. Hope this clarifies 😊 |
|
Due to Knack page hierarchy, the footer was appearing on child pages not indicated by the array so now the logic is checking for an exact match and we exclude on scenes not indicated in the array. Tested on PTE and the footer is now appearing correctly on all indicated scenes whether a standard page or modal. The city website change did not change the url so the existing url is still applicable. This is now ready for re-review and potential prod implementation. |
There was a problem hiding this comment.
This looks fine to me looking at the ROW PTE. I see the variable to update on public-facing web apps would be stored in the footerHashes array that lists the specific page slugs to inject it.
I would prefer to have it exclude modal pop-ups from injecting footers, but their could bespecific situations where you do inject a footer.
I've been looking at the MutableObserver() and this could be useful for addressing accessibility for dynamic content in some of Knack's forms.
This work is to elevate the requirement to post the City of Austin Privacy Policy on public facing Knack pages. Instead of manual maintenance, this code provides us an easy way to maintain an array of scenes we would like to target in an app, use standard CSS styling, and have the footer display appropriately on either standard or modal pages. The footer has been centered with the COA branding and a link to the Privacy Policy. The code has been wrapped and uses the image stored on our Knack Media Gitbook. The Footer should appear at the bottom of a page either on load or when the url hash changes.
This is currently live on the ROW PTE and is a WIP and now available for testing