Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gta-streaming-five): Background minimap overlays #3219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(gta-streaming-five): Background minimap overlays #3219

wants to merge 1 commit into from
+45 −16

Conversation

manzarek123
Copy link
Contributor

@manzarek123 manzarek123 commented Mar 7, 2025 •
edited
Loading

Goal of this PR

Allow the creation of background overlays with AddMinimapOverlay and AddMinimapOverlayWithDepth.
This will allow to create overlay behind the GPS or Radius Blip, as well as automatic transparency on minimap
roxwood1

...

How is this PR achieving the goal

By adding a new argument to the natives
...

This PR applies to the following area(s)

FiveM
...

Successfully tested on

Game builds: 1604, 3095, 3407

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

@DaniGP17
Copy link
Contributor

DaniGP17 commented Mar 7, 2025

Adding a new argument can cause existing scripts to stop working or I'm wrong?

@manzarek123
Copy link
Contributor Author

The default (false) will create a foreground overlay like it was before

@DaniGP17
Copy link
Contributor

DaniGP17 commented Mar 7, 2025

But for example C# forces you to send all the arguments to invoke natives, it don't have default values

@manzarek123
Copy link
Contributor Author

Ho ok let me check that then, didn't know about that :)

@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Mar 7, 2025
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action and removed invalid Requires changes before it's considered valid and can be (re)triaged labels Mar 7, 2025
@manzarek123
Copy link
Contributor Author

Thanks, I splitted the definition for C# compatibility

@github-actions github-actions bot added invalid Requires changes before it's considered valid and can be (re)triaged and removed triage Needs a preliminary assessment to determine the urgency and required action labels Mar 7, 2025
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action labels Mar 11, 2025
@github-actions github-actions bot added triage Needs a preliminary assessment to determine the urgency and required action invalid Requires changes before it's considered valid and can be (re)triaged and removed invalid Requires changes before it's considered valid and can be (re)triaged triage Needs a preliminary assessment to determine the urgency and required action labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AvarianKnight AvarianKnight AvarianKnight left review comments

Assignees
No one assigned
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manzarek123 @DaniGP17 @AvarianKnight