-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gta-core-five): increase ped alternate variations #3190
base: master
Are you sure you want to change the base?
feat(gta-core-five): increase ped alternate variations #3190
Conversation
Co-Authored-By: slashkeyvalue <[email protected]>
5ad26b0
to
99fab04
Compare
This might be merged once #3195 is in production. |
But dependency PR is not server side change, probably they can be just merged together one by one? |
Yes, both could be merged one by one, but
Yes, it's perfect, I've already tried it and it seems to work, but if more people try it and confirm that it works well, then even better. |
Ah, right, key_value is right. |
Goal of this PR
Try increasing the hard-coded size for
Ped Alternate Variations
. This is just an untested attempt as I haven't had the resources to reproduce the issue but I'll try to test it with someone to confirm if this actually works.Currently looking for reproduction resources to test if this work, if you have you can send to me in discord
danielgp
.How is this PR achieving the goal
By patching all the sizes passed to the
alloca
function calculating the new size of the alternate varations, I have increased it to double the original value, that is, to 320.This PR applies to the following area(s)
FiveM
Successfully tested on
Game builds: At least patterns work in b1 & b3095
Platforms: Windows
Checklist
Fixes issues
fixes #2760