fix(gta-core-five): validate bounds collisions

[DaniGP17]

Goal of this PR

Fix a game crash when two collisions collide with each other without having a valid m_Bounds. This is happening for specific objects, mostly testing objects that are not used in the map but are spawned by malicious players to make people nearby crash. By default when spawning the prop there is no problem, but if the player or something external hits a sub-object that makes it move and collide with another sub-object of the same object it will reproduce this crash.

How is this PR achieving the goal

Hooking the ProcessSelfCollision function and validating that the boundComposite and boundComposite->m_Bounds are valid

This PR applies to the following area(s)

FiveM

Successfully tested on

Game builds: 1, 1604, 2060, 2189, 2372, 2545, 3095, 3258, 3407

Platforms: Windows

Checklist

• Code compiles and has been tested successfully.
• Code explains itself well and/or is documented.
• My commit message explains what the changes do and what they are for.
• No extra compilation warnings are added by these changes.

Fixes issues

fixes #3173

[ook3D]

for where you defined the phBound structs, would it be possible to use the already defined ones inside rage-formats-x component to prevent duplicating code? https://github.com/citizenfx/fivem/tree/master/code/components/rage-formats-x/include

[DaniGP17]

for where you defined the phBound structs, would it be possible to use the already defined ones inside rage-formats-x component to prevent duplicating code? https://github.com/citizenfx/fivem/tree/master/code/components/rage-formats-x/include

I didn't realize that, I'll do it thanks

[DaniGP17]

Can the phBound structure from the rage-formats-x project be easily referenced from gta-core-five?

[Gogsi]

Can the phBound structure from the rage-formats-x project be easily referenced from gta-core-five?

You can add "rage:formats:x" as a dependency in component.json and rerun fxd gen -game five and fxd vs -game five.
That should be enough to reference the project, hopefully it doesn't cause other issues.

[DaniGP17]

I've tried using phBoundComposite from the rage-formats-x project but the m_childBounds member is private, should I change it to public or leave the structure as I have it?

[ook3D]

I've tried using phBoundComposite from the rage-formats-x project but the m_childBounds member is private, should I change it to public or leave the structure as I have it?

Probably best to leave it how you have it originally then

[xliel]

Is there a way to block this using natives for now until you get approval?