Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add GET_PLAYER_PEER_STATISTICS to get useful peer stats #3162

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AvarianKnight
Copy link
Contributor

This adds the ability to get packet loss, packet loss variance, and round trip time variance, rtt is already revealed via GET_PLAYER_PING but this still re-adds it for consistency

Having some Prometheus endpoints here might make sense in the future, not sure if adding more endpoints is wanted outside of perf specific stuff though.

This PR applies to the following area(s)

Server

Successfully tested on

Platforms: Windows

Checklist

  • Code compiles and has been tested successfully.
  • Code explains itself well and/or is documented.
  • My commit message explains what the changes do and what they are for.
  • No extra compilation warnings are added by these changes.

This adds the ability to get packet loss, packet loss variance, and
round trip time variance, rtt is already revealed via
GET_PLAYER_PING
@github-actions github-actions bot added the invalid Requires changes before it's considered valid and can be (re)triaged label Feb 17, 2025
@tabarra
Copy link
Contributor

tabarra commented Feb 18, 2025

Cool PR, but why not return everything instead of single items per native call?

@AvarianKnight
Copy link
Contributor Author

AvarianKnight commented Feb 18, 2025

Cool PR, but why not return everything instead of single items per native call?

It could be done this way, I'm not sure what the overhead would be for this vs just a regular native call, it might make sense to have a native for each.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid Requires changes before it's considered valid and can be (re)triaged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants