Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ASM-sync endpoint and scan CRASM-2437 #831

Draft
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

DJensen94
Copy link
Contributor

🗣 Description

Create an endpoint that pulls recent changes to the ASM sync asset data (Ips and Subdomains)
Create a scan to be run on the LZ to pull the changes from the DMZ
Implement checksums to validate data passed successfully without man in the middle attacks

💭 Motivation and context

We want to keep the LZ and DMZ asset data in sync between the two databases

🧪 Testing

xfd_api/tests/test_dmz_sync.py contains a set of tests to validate endpoint is functioning as envisioned

Also ran tests in a local environment with two Mini data lakes stood up to test the full flow of data from DMZ to LZ.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All future TODOs are captured in issues, which are referenced
    in code comments.
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

Create asm sync sync scan
Add endpoint and scan to sync environments
clean up code
fix mismatched return statements
Add default salt to import
add sync scan name to front end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant