Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring and New Init Features #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Refactoring and New Init Features #38

wants to merge 4 commits into from

Conversation

BribeFromTheHive
Copy link

  • Refactored built-in initialization to take into account the different variations offered by Total Initialization.
  • Now uses pcall for initialization calls instead of unsafe calling.
  • Removed fromObject and overloads for fromHandle.

@BribeFromTheHive
* Refactored built-in initialization to take into account the differe…
7ab97b6 
…nt variations offered by Total Initialization.

* Now uses pcall for initialization calls instead of unsafe calling.
* Removed fromObject and overloads for fromHandle.
cipherxof
cipherxof reviewed Jan 16, 2024
View reviewed changes
@BribeFromTheHive
Copy link
Author

BribeFromTheHive commented Jan 21, 2024 •
edited
Loading

@cipherxof please let me know how it looks now with the changes made.

cipherxof
cipherxof reviewed Jan 22, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherxof cipherxof cipherxof left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BribeFromTheHive @cipherxof