-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTTP URL filter #1236
Add HTTP URL filter #1236
Conversation
a1dcc14
to
2eda984
Compare
Commit 04f7aac does not match "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/contributing/#developer-s-certificate-of-origin |
Static check failed with
Consider increasing golangci-lint timeout in a first commit to something like 5m here. |
Signed-off-by: Fabian Fischer <[email protected]>
We added support for filtering on HTTP URLs in cilium/cilium#28275. This PR adds this feature in the CLI by adding a new flag `--http-url` Fixes: cilium#925 Signed-off-by: Fabian Fischer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @glrf, patch LGTM.
Note for reviewers: the huge diff in the first commit updating cilium is caused by cilium/cilium#27854 which is pulling in the whole Cilium policy modules into the Hubble API (see this main
branch commit). I was curious and did this to investigate:
% go get github.com/cilium/cilium@86a6ab94fdf286971fb26cca97f4c2d0cc15da74
% go mod tidy && go mod vendor && go mod verify
% git add .
% git diff --cached --shortstat
82 files changed, 4199 insertions(+), 1588 deletions(-)
% go get github.com/cilium/cilium@6fcad1351103594602767024c1e2d17816f69f34
% go mod tidy && go mod vendor && go mod verify
% git add .
% git diff --cached --shortstat
3756 files changed, 1072929 insertions(+), 1704 deletions(-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
We added support for filtering on HTTP URLs in cilium/cilium#28275. This PR adds this feature in the CLI by adding a new flag
--http-url
Fixes: #925