Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: Implement simple "sed" command #29

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

joamaki
Copy link
Contributor

@joamaki joamaki commented Dec 5, 2024

The simple 'replace' command falls short in situations where the input text isn't fully known, but still needs to be sanitized in some way. Instead of having to use e.g. the system 'sed' command, implement a very simple built-in version.

@joamaki joamaki requested a review from rastislavs December 5, 2024 14:23
@joamaki joamaki requested a review from a team as a code owner December 5, 2024 14:24
@joamaki joamaki requested review from pippolo84 and removed request for a team December 5, 2024 14:24
Copy link

@rastislavs rastislavs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool :) thanks!

@joamaki joamaki force-pushed the pr/joamaki/script-sed-command branch from b63e30b to 2d90365 Compare December 5, 2024 14:45
The simple 'replace' command falls short in situations
where the input text isn't fully known, but still needs
to be sanitized in some way. Instead of having to use e.g.
the system 'sed' command, implement a very simple built-in
version.

Signed-off-by: Jussi Maki <[email protected]>
@joamaki joamaki force-pushed the pr/joamaki/script-sed-command branch from 2d90365 to fe48433 Compare December 13, 2024 10:13
@joamaki joamaki requested a review from pippolo84 December 13, 2024 10:14
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@joamaki joamaki merged commit 553aca4 into main Dec 13, 2024
1 check passed
@joamaki joamaki deleted the pr/joamaki/script-sed-command branch December 13, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants