bpf2go: ergonomic enums #1636
Open
bpf2go: ergonomic enums #1636
+108
−96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mejedi
force-pushed
the
ergonomic-enums
branch
from
0c3db6f to
345d337
Compare
mejedi
force-pushed
the
ergonomic-enums
branch
from
345d337 to
ad7e33b
Compare
bpf2go orders generated types by name to ensure the output is stable. Adjust data structures such that we can rely on implicit sorting in text/template, removing sortTypes alltogether. The added reservedNames hash is handy for rejecting "reserved" type names such as "<STEM>Specs", and for the upcoming "ergonomic" enum feature (generate short names for enum members if not yet taken). Signed-off-by: Nick Zavaritsky <[email protected]>
mejedi
force-pushed
the
ergonomic-enums
branch
from
ad7e33b to
d3bc971
Compare
Constant names emitted for enum elements end up quite unwieldy. They are
prefixed with enum name because in C struct, union and enum names are in
a separate namespace, allowing for overlaps with identifiers, e.g:
enum E { E };
While such overlaps are possible in *theory*, people usually don't do
it. If a typicall C naming convention is followed, we get
enum something {
SOMETHING_FOO, SOMETHING_BAR
};
generating <STEM>SomethingSOMETHING_FOO and <STEM>SomethingSOMETHING_BAR.
In addition to "safe" long names, generate shorter ones if the
respective name is not taken. <STEM>SOMETHING_FOO and
<STEM>SOMETHING_BAR are much nicer to work with.
Signed-off-by: Nick Zavaritsky <[email protected]>
mejedi
force-pushed
the
ergonomic-enums
branch
from
d3bc971 to
12b600e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constant names emitted for enum elements end up quite unwieldy. They are
prefixed with enum name because in C struct, union and enum names are in
a separate namespace, allowing for overlaps with identifiers, e.g:
While such overlaps are possible in theory, people usually don't do
it. If a typicall C naming convention is followed, we get
generating
<STEM>SomethingSOMETHING_FOOand<STEM>SomethingSOMETHING_BAR.In addition to "safe" long names, generate shorter ones if the
respective name is not taken.
<STEM>SOMETHING_FOOand<STEM>SOMETHING_BARare much nicer to work with.