Skip to content

Pydantic #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Pydantic #308

wants to merge 3 commits into from

Conversation

@tony
Copy link
Member

@tony tony commented Feb 3, 2024 •
edited
Loading

@codecov
Copy link

codecov bot commented Feb 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.57143% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (ab004f7) to head (b0e7885).
Report is 1 commits behind head on master.

❗ Current head b0e7885 differs from pull request most recent head 408f1ac

Please upload reports for the commit 408f1ac to get more accurate results.

Files Patch % Lines
src/unihan_etl/validator.py 83.33% 3 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
+ Coverage   67.19%   67.74%   +0.54%     
==========================================
  Files          12       14       +2     
  Lines        1256     1296      +40     
  Branches      231      235       +4     
==========================================
+ Hits          844      878      +34     
- Misses        356      361       +5     
- Partials       56       57       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tony tony force-pushed the pydantic branch 5 times, most recently from d8f7b9f to ced7481 Compare February 5, 2024 13:16
@tony tony mentioned this pull request Feb 5, 2024
Merged
tony added a commit that referenced this pull request Feb 5, 2024
@tony
chore: Misc tweaks for typings, pytest watching (#312)
f102b09 
Extracted from #308

Changes:
- pytest-watcher: Ignore vim files
- `kTGH2013` typings and tests, improve typing
@tony tony force-pushed the pydantic branch 5 times, most recently from 936cd0f to b0e7885 Compare February 7, 2024 23:51
@tony tony force-pushed the pydantic branch 2 times, most recently from 035e08d to d620999 Compare April 20, 2024 00:13
@tony tony force-pushed the pydantic branch 4 times, most recently from ad3d46f to 408f1ac Compare June 23, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tony