fix当页面有滚动条时定位不准确，采用relative+absoluete定位体系，支持列表多个元素hover效果 #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fanerge Thank for the contribution. I will review this change soon. |
|
What do you think about this change? |
shineli1984
suggested changes
Oct 28, 2018
| @@ -90,7 +95,7 @@ class ReactHover extends Component { | |||
| if (isNaN(shiftY)) { | |||
| shiftY = 0 | |||
| } | |||
| updatedStyles = { ...hoverComponentStyle, top: cursorY + shiftY, left: cursorX + shiftX } | |||
| updatedStyles = { ...hoverComponentStyle, top: cursorY + shiftY - domPos.y, left: cursorX + shiftX - domPos.x } | |||
There was a problem hiding this comment.
According to https://caniuse.com/#search=getBoundingClientRect, the return value for getBoundingClientRect lacks x and y for ie and edge, we can use left and top to cover these 2 browsers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
进行优化一下：
fix当页面有滚动条时定位不准确，
采用relative+absoluete定位体系，
支持列表多个元素hover效果