[CHORE] Fix the MCMR memberlists in Tilt.

[rescrv]

Description of changes

The frontend was failing to come up. Extend permissions to access memberlist.

Test plan

CI

Migration plan

N/A

Observability plan

N/A

Documentation Changes

N/A

[github-actions]

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

• Can you think of any use case in which the code does not behave as intended? Have they been tested?
• Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
• If appropriate, are there adequate property based tests?
• If appropriate, are there adequate unit tests?
• Should any logging, debugging, tracing information be added or removed?
• Are error messages user-friendly?
• Have all documentation changes needed been made?
• Have all non-obvious changes been commented?

System Compatibility

• Are there any potential impacts on other parts of the system or backward compatibility?
• Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

• Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

[propel-code-bot]

Tilt updates to grant rust frontend memberlist access

Adds missing rust-frontend-service service account, role, and role binding references to the Tilt-managed Kubernetes resource bootstrap for both chroma and chroma2 environments. Also extends the sysdb bootstrap list to include the rust-log-service memberlist bindings so the frontend can enumerate memberlists at startup.

Key Changes

• Added rust-frontend-service service account and role bindings to the k8s_setup object list
• Mirrored the new rust-frontend-service resources in the k8s_setup2 definition
• Included sysdb-rust-log-service-memberlist-binding in both namespace bootstrap lists

Affected Areas

• Tiltfile

This summary was automatically generated by @propel-code-bot

[propel-code-bot]

[Maintainability] These new resource definitions are also duplicated for the chroma2 namespace below (lines 314-318). The entire objects list for k8s_setup and k8s_setup2 is almost identical.

To avoid future inconsistencies and make this file easier to maintain, consider abstracting the resource list into a function that takes the namespace as an argument. This would centralize the resource definitions and ensure both environments stay in sync.

For example:

def get_k8s_setup_objects(namespace):
  return [
    'pod-watcher:Role:{}'.format(namespace),
    # ... (rest of the common resources)
    'rust-frontend-service-serviceaccount:ServiceAccount:{}'.format(namespace),
    'rust-frontend-service-rolebinding:RoleBinding:{}'.format(namespace),
    'rust-frontend-service-query-service-memberlist-binding:RoleBinding:{}'.format(namespace),
    'rust-log-service-memberlist-readerwriter:Role:{}'.format(namespace),
    'rust-frontend-service-rust-log-service-memberlist-binding:RoleBinding:{}'.format(namespace),
    # ...
  ]

k8s_resource(
  objects=get_k8s_setup_objects('chroma'),
  new_name='k8s_setup',
  labels=["infrastructure"],
)

k8s_resource(
  objects=get_k8s_setup_objects('chroma2'),
  new_name='k8s_setup2',
  labels=["infrastructure2"],
)

Applying this pattern would make adding or removing resources for both environments a single-line change.

Context for Agents

These new resource definitions are also duplicated for the `chroma2` namespace below (lines 314-318). The entire `objects` list for `k8s_setup` and `k8s_setup2` is almost identical.

To avoid future inconsistencies and make this file easier to maintain, consider abstracting the resource list into a function that takes the namespace as an argument. This would centralize the resource definitions and ensure both environments stay in sync.

For example:
```python
def get_k8s_setup_objects(namespace):
  return [
    'pod-watcher:Role:{}'.format(namespace),
    # ... (rest of the common resources)
    'rust-frontend-service-serviceaccount:ServiceAccount:{}'.format(namespace),
    'rust-frontend-service-rolebinding:RoleBinding:{}'.format(namespace),
    'rust-frontend-service-query-service-memberlist-binding:RoleBinding:{}'.format(namespace),
    'rust-log-service-memberlist-readerwriter:Role:{}'.format(namespace),
    'rust-frontend-service-rust-log-service-memberlist-binding:RoleBinding:{}'.format(namespace),
    # ...
  ]

k8s_resource(
  objects=get_k8s_setup_objects('chroma'),
  new_name='k8s_setup',
  labels=["infrastructure"],
)

k8s_resource(
  objects=get_k8s_setup_objects('chroma2'),
  new_name='k8s_setup2',
  labels=["infrastructure2"],
)
```
Applying this pattern would make adding or removing resources for both environments a single-line change.

File: Tiltfile
Line: 274

[sanketkedia]

Just to confirm my understanding - this isn't MCMR specific right? FE in chroma namespace also has the same issue when accessing query service memberlist for e.g.?

[propel-code-bot]

[Logic] The path column is defined as STRING(64), which may be too short for fragment paths generated with sequence numbers.

The path format for sequence-numbered fragments is log/Bucket={:016x}/FragmentSeqNo={:016x}.parquet, which results in a 66-character string (e.g., log/Bucket=0000000000000000/FragmentSeqNo=0000000000000001.parquet). This will cause an error when inserting into the fragments table.

Consider increasing the size of the path column to accommodate these longer paths, for example, STRING(128).

Context for Agents

The `path` column is defined as `STRING(64)`, which may be too short for fragment paths generated with sequence numbers.

The path format for sequence-numbered fragments is `log/Bucket={:016x}/FragmentSeqNo={:016x}.parquet`, which results in a 66-character string (e.g., `log/Bucket=0000000000000000/FragmentSeqNo=0000000000000001.parquet`). This will cause an error when inserting into the `fragments` table.

Consider increasing the size of the `path` column to accommodate these longer paths, for example, `STRING(128)`.

File: rust/spanner-migrations/log_migrations/0002-create_fragments_table.spanner.sql
Line: 4

[rescrv]

It's log-uuid that gets used here. log/Uuid={}.parquet fits a 36-char UUID in 64 chars.