-
Notifications
You must be signed in to change notification settings - Fork 2k
[ENH] Log masked search queries #6077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Reviewer ChecklistPlease leverage this checklist to ensure your code review is thorough before approving Testing, Bugs, Errors, Logs, Documentation
System Compatibility
Quality
|
c23ec5b to
d66234c
Compare
|
Add masked logging for collection search payloads Introduces masking utilities across the search planning types so that request data can be logged without exposing user content. Server-side tracing for Key Changes• Adds Affected Areas• This summary was automatically generated by @propel-code-bot |
d66234c to
ab0b739
Compare
## Description of changes _Summarize the changes made by this PR._ - Improvements & Bug fixes - / - New functionality - Adds read level to the query nodes. When read level is IndexAndWal it reads both indexAndWal, IndexOnly skips the Wal. This is a simple change in the orchestrator. ## Test plan _How are these changes tested?_ Tests will be handled e2e at the top of the stack in client changes - [ ] Tests pass locally with `pytest` for python, `yarn test` for js, `cargo test` for rust ## Migration plan This param will default to IndexAndWal to preserve existing behavior. ## Observability plan Added trace to log this is being used. In conjuction with #6077 this should be sufficient. ## Documentation Changes Updated relevant code docs

Description of changes
Summarize the changes made by this PR.
SearchPayload::masked, which allows us to log the structure of user query with masked valuesTest plan
How are these changes tested?
pytestfor python,yarn testfor js,cargo testfor rustMigration plan
Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?
Observability plan
What is the plan to instrument and monitor this change?
Documentation Changes
Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?