Skip to content

Conversation

@benodiwal
Copy link

Description of changes

Summarize the changes made by this PR.

Test plan

How are these changes tested?

  • Verified pytest collection error is reproduced with duplicate basenames
  • Verified pytest collection succeeds after rename
  • Confirmed no other duplicate test file basenames exist in the test suite

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

None. This is an internal test file rename with no external dependencies.

Observability plan

What is the plan to instrument and monitor this change?

None required. CI test collection will pass where it previously failed.

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

None required. Internal test file only.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

Rename test_schema.py to avoid pytest collection collision

Renamed the API test module from chromadb/test/api/test_schema.py to chromadb/test/api/test_schema_types.py to eliminate a basename clash with chromadb/test/property/test_schema.py. This resolves pytest collection failures caused by the duplicate test module names.

Key Changes

• Renamed chromadb/test/api/test_schema.py to chromadb/test/api/test_schema_types.py to prevent pytest basename collision with chromadb/test/property/test_schema.py.

Affected Areas

chromadb/test/api

This summary was automatically generated by @propel-code-bot

@benodiwal benodiwal changed the title [BUG]: Rename test_schema.py to test_schema_types.py to fix pytest collection collision [BUG] Rename test_schema.py to test_schema_types.py to fix pytest collection collision Dec 13, 2025
@sanketkedia sanketkedia self-requested a review January 8, 2026 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: ERROR collecting chromadb/test/property/test_schema.py

1 participant