Skip to content

Conversation

@MrCroxx
Copy link
Contributor

@MrCroxx MrCroxx commented Dec 10, 2025

Description of changes

Summarize the changes made by this PR.

  • Improvements & Bug fixes
    • Upgrade foyer to v0.21.0 with intrusive linked list atomic ptr patches.
  • New functionality
    • No user-facing changes.

Test plan

How are these changes tested?

  • Tests pass locally with pytest for python, yarn test for js, cargo test for rust

Migration plan

Are there any migrations, or any forwards/backwards compatibility changes needed in order to make sure this change deploys reliably?

Observability plan

What is the plan to instrument and monitor this change?

Documentation Changes

Are all docstrings for user-facing APIs updated if required? Do we need to make documentation changes in the docs section?

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@github-actions
Copy link

Reviewer Checklist

Please leverage this checklist to ensure your code review is thorough before approving

Testing, Bugs, Errors, Logs, Documentation

  • Can you think of any use case in which the code does not behave as intended? Have they been tested?
  • Can you think of any inputs or external events that could break the code? Is user input validated and safe? Have they been tested?
  • If appropriate, are there adequate property based tests?
  • If appropriate, are there adequate unit tests?
  • Should any logging, debugging, tracing information be added or removed?
  • Are error messages user-friendly?
  • Have all documentation changes needed been made?
  • Have all non-obvious changes been commented?

System Compatibility

  • Are there any potential impacts on other parts of the system or backward compatibility?
  • Does this change intersect with any items on our roadmap, and if so, is there a plan for fitting them together?

Quality

  • Is this code of a unexpectedly high quality (Readability, Modularity, Intuitiveness)

@propel-code-bot
Copy link
Contributor

Upgrade foyer to v0.21.0 and align cache integration

Updates the Rust cache layer to work with foyer v0.21.0, replacing the legacy device and engine builders with the new block engine APIs and wiring in the asynchronous psync I/O engine. The change removes the deprecated obtain cache method across cache implementations and callers, updates configuration defaults to match the new engine semantics, and propagates foyer::FoyerError through CacheError so downstream layers receive typed errors.

Key Changes

• Switch rust/cache/src/foyer.rs to the new BlockEngineBuilder, FsDeviceBuilder, and PsyncIoEngineBuilder, configure throttling, buffer pool size, and adopt foyer::RecoverMode::Quiet.
• Expose foyer::Error as FoyerError, replace the DiskError variant with FoyerError in CacheError, and drop the unused obtain method from the cache traits and implementations.
• Adjust blockstore cache consumers (rust/blockstore/src/arrow/provider.rs) to use get instead of obtain and ensure cache hits continue to short-circuit remote fetches.
• Update crate metadata to pull foyer from commit d86a8879 and bump mixtrics to 0.2.3 for API compatibility.

Affected Areas

rust/cache/src/foyer.rs
rust/cache/src/lib.rs
rust/cache/src/unbounded.rs
rust/cache/src/nop.rs
rust/blockstore/src/arrow/provider.rs
rust/cache/Cargo.toml
Cargo.lock

This summary was automatically generated by @propel-code-bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant