Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sankey: explicit <xhtml:pre> instead of <xhtml:body> for bootstrap-datepicker compatibility #215

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Sankey: explicit <xhtml:pre> instead of <xhtml:body> for bootstrap-datepicker compatibility #215

wants to merge 2 commits into from

Conversation

octaviancorlade
Copy link
Contributor

Removes the necessity of declaring a new namespace for each <title> using the xhtml:body tag, since there is only one xhtml:pre for each title in any case.

Working on Chrome 60.0.3112.113, FF 55.0.3, Safari 10.1.2, IE11.

Fixes #214

@cjyetman cjyetman mentioned this pull request Sep 18, 2017
Closed
@octaviancorlade octaviancorlade mentioned this pull request Sep 27, 2017
Closed
@octaviancorlade
Copy link
Contributor Author

octaviancorlade commented Sep 27, 2017 •
edited
Loading

Just to keep track of what was found with some more testing (see comments on Issue #214):

No reason to use xhtml:pre instead of pre, since the namespace is removed in d3.selection.append() and therefore doesn't affect the result.

No reason to remove the foreignObject tag, which would be semantically more correct.

Just removing the .append("xhtml:body") should be enough.

Consistency in appending .html() or .text() would be a good idea, probably using .text() with \n for new lines is easier inside pre.

@cjyetman
Copy link
Collaborator

I haven't actually tested this, but based on the discussion and what I know/remember, this gets my seal of approval. Using the <foreignObject> tag I think is necessary for older browser compatibility, but use of the <body> tag, namespaced or not, seems to cause conflicts with other JavaScript packages when they select elements in the DOM.

@cjyetman cjyetman mentioned this pull request Feb 15, 2019
Closed
@cjyetman
Copy link
Collaborator

this would probably fix #250 as well

@cjyetman cjyetman mentioned this pull request Feb 24, 2019
Open
@cjyetman
Copy link
Collaborator

cjyetman commented Apr 9, 2019

The problem that this was intended to workaround has been fixed upstream in shiny, so I'm not sure this needs to be merged anymore. Will leave open for now though as this may be a better strategy than the current one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug sankeyNetwork
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@octaviancorlade @cjyetman