Skip to content

Conversation

@blueyed
Copy link
Collaborator

@blueyed blueyed commented Apr 30, 2018

  • use a list instead of single string
  • add s:GetTmuxCommand to be used later when not using system() only
  • remove :silent when calling tmux from s:TmuxAwareNavigate: it
    should not be necessary and is bad practice to use :silent
    unnecessarily. It was added in b068a04 with no explanation.

- use a list instead of single string
- add s:GetTmuxCommand to be used later when not using `system()` only
- remove `:silent` when calling tmux from `s:TmuxAwareNavigate`: it
  should not be necessary and is bad practice to use `:silent`
  unnecessarily.  It was added in b068a04 with no explanation.
@christoomey
Copy link
Owner

christoomey commented May 3, 2018

Broadly these changes all look good to me, but unfortunately I'm getting an error when running with this locally:

Error detected while processing function <SNR>151_TmuxWinCmd[2]..<SNR>151_TmuxAwareNavigate[23]..<SNR>151_TmuxCommand:
line    2:
E730: using List as a String

Any thoughts on what the issue might be?


Adding a bit more detail, I'm able to move between Vim panes, but hit the above error when attempting to navigate from Vim -> tmux.

@blueyed
Copy link
Collaborator Author

blueyed commented May 16, 2018

@christoomey
The problem is that Vim's system() does not handle lists for the command/argv. Will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants