-
Notifications
You must be signed in to change notification settings - Fork 0
fix: bring code into compliance with standards & cleanup documentation #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
chrislyons-dev
commented
Jan 1, 2026
- add unit tests
- add quality assertions: test coverage, security checks
- documentation improvements: remove inconsistencies and inaccuracies
Update Astro (5.16.4 → 5.16.6), React (19.2.1 → 19.2.3), Tailwind CSS (4.1.17 → 4.1.18), TypeScript ESLint (8.48.1 → 8.51.0), Vitest (4.0.15 → 4.0.16), and other dependencies to latest versions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR enhances the codebase's quality standards by adding unit tests, implementing security scanning with secretlint and eslint-plugin-security, enabling code coverage enforcement (80% thresholds), and improving TypeScript strictness with noUncheckedIndexedAccess. The documentation has been streamlined to remove inconsistencies and clarify deployment processes.
Key changes:
- Add comprehensive unit tests for diagram generation script with 100% coverage
- Enable test coverage thresholds (80%) and TypeScript strict index access checking
- Integrate secretlint for secret detection and eslint-plugin-security for static analysis
Reviewed changes
Copilot reviewed 20 out of 83 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Adds 80% coverage thresholds for lines, functions, branches, and statements |
| tsconfig.json | Enables noUncheckedIndexedAccess for stricter array/object access |
| src/types/eslint-plugin-security.d.ts | Type declaration for eslint-plugin-security |
| src/tests/projects.test.ts | Adds null checks for array access due to noUncheckedIndexedAccess |
| src/scripts/*.js | Removes redundant eslint-env browser comments in favor of explicit globals |
| src/components/CodeBlock.tsx | Adds guards for empty arrays and undefined access |
| scripts/generate-diagram-images.unit.test.mjs | New comprehensive unit test suite |
| scripts/generate-diagram-images.mjs | Exports functions for testability and adds proper entrypoint detection |
| package.json | Adds security tools, updates dependencies, enhances check script |
| eslint.config.js | Integrates eslint-plugin-security |
| docs/security.md | Updates to reflect current tooling choices (secretlint, npm audit) |
| docs/index.md | Simplified marketing language |
| docs/deployment/overview.md | Clarifies CI/CD behavior |
| README.md | Simplified marketing language |
| .secretlintrc.json | Configuration for secret scanning |
| .husky/pre-commit | Adds secret and audit scans |
| .github/workflows/ci.yml | Adds security scans, enables coverage, removes continue-on-error |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.husky/pre-commit
Outdated
| echo "dY"? Running secret scan..." | ||
| npx secretlint **/* | ||
|
|
||
| echo "dY"? Running npm audit..." |
Copilot
AI
Jan 1, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in echo statement. Should be an emoji or a proper opening quote.
| echo "dY"? Running secret scan..." | |
| npx secretlint **/* | |
| echo "dY"? Running npm audit..." | |
| echo "🕵️ Running secret scan..." | |
| npx secretlint **/* | |
| echo "🛡️ Running npm audit..." |