Refactor Mermaid: centralized init, sequential rendering, robust errors #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…optimized layout - Add global font support for Chinese, Japanese, Korean, Arabic, Hindi and other major languages - Optimize print margins with binding-friendly layout (left 2cm, others 1.5cm) - Improve print typography with proper page breaks and clean backgrounds - Preserve text colors while removing background interference - Update README with detailed print features documentation
- Add new --no-reload flag to disable WebSocket-based auto-refresh - Provide clear user feedback about current refresh mode - Maintain backward compatibility with auto-reload enabled by default - Include WebSocket CORS fix when reload is enabled for development use - Update README with usage example for stable editing workflow
… and robust error display - Move Mermaid script loading to layout template; remove per-snippet init - Add mermaid-init.js to compute theme, init once, and render all diagrams - Render diagrams sequentially to avoid race conditions on multi-graph pages - Use mermaid.render/mermaidAPI.render with broad version compatibility - Surface parse/render errors both inline (.mermaid-error) and in console - Preserve original code in data-code for safe re-rendering - Add github-mermaid.css for clear error styles and dark mode support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Refactors Mermaid integration for stability on pages with many diagrams and better debuggability.
Key changes
Why
Previously, multi-graph pages could randomly leave some diagrams blank with no console error due to concurrent rendering and version-specific API behavior. Centralizing init and sequential rendering makes behavior predictable and debuggable.
Notes
Future (optional)