Add possibility to add and drop hpke configs #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 3, 2025
thibmeu
reviewed
Feb 3, 2025
Oupsi, use it to check misspelled words or the grammar of some sentences, here you go :): cloudflare/privacy-gateway-server-go#68 Thanks for you quick review ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR aims to enable the dynamic addition and removal of HPKE configurations on a specific gateway during runtime.
Why
For example, as highlighted in this issue, to support key rotation, it is crucial to have the ability to automatically remove expired HPKE configurations and their associated keys after a defined cryptoperiod instead of re-creating the entire gateway.