Skip to content

Use rustc-serialize instead of serialize crate#6

Closed
cyderize wants to merge 2 commits intochris-morgan:masterfrom
cyderize:master
Closed

Use rustc-serialize instead of serialize crate#6
cyderize wants to merge 2 commits intochris-morgan:masterfrom
cyderize:master

Conversation

@cyderize
Copy link
Contributor

The serialize crate is being deprecated in favour of the one from
crates.io. PR: rust-lang/rust#19820.

Also, I changed the deprecated into_string() call to to_string(), although maybe I should be using to_owned() from std::borrow::ToOwned?

The serialize crate is being deprecated in favour of the one from
crates.io.
into_string() is deprecated
@chris-morgan
Copy link
Owner

I'm much more inclined to just remove that part; there's really no reason
to add that dependency that I can see. The purpose of libserialize has been
clarified (it's for rustc) and mucell doesn't fit into that.

(I haven't taken action on this yet as I am on a very dodgy and slow
Internet connection for a few days; I'll probably take action early next
week.)

@cyderize
Copy link
Contributor Author

That makes sense. I've created a PR #7 that removes the libserialize dependency, if that's useful to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants