Use rustc-serialize instead of serialize crate#6
Closed
cyderize wants to merge 2 commits intochris-morgan:masterfrom
Closed
Use rustc-serialize instead of serialize crate#6cyderize wants to merge 2 commits intochris-morgan:masterfrom
cyderize wants to merge 2 commits intochris-morgan:masterfrom
Conversation
The serialize crate is being deprecated in favour of the one from crates.io.
into_string() is deprecated
Owner
|
I'm much more inclined to just remove that part; there's really no reason (I haven't taken action on this yet as I am on a very dodgy and slow |
Contributor
Author
|
That makes sense. I've created a PR #7 that removes the libserialize dependency, if that's useful to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The serialize crate is being deprecated in favour of the one from
crates.io. PR: rust-lang/rust#19820.
Also, I changed the deprecated into_string() call to to_string(), although maybe I should be using to_owned() from std::borrow::ToOwned?