Skip to content

Nanohtml#109

Merged
yoshuawuyts merged 9 commits intomasterfrom
nanohtml
Mar 12, 2018
Merged

Nanohtml#109
yoshuawuyts merged 9 commits intomasterfrom
nanohtml

Conversation

@yoshuawuyts
Copy link
Copy Markdown
Member

@yoshuawuyts yoshuawuyts commented Mar 9, 2018 •
edited
Loading

Changes bel into nanohtml. The main goal here is to merge bel, yoyoify and pelo into a single module that does all of these things. This should make it easier to maintain, test and point people to the right modules. Thanks!

Tasks

  • port bel to nanohtml
  • port benchmarks
  • port tests
  • port types
  • release major & deprecate bel
  • release major & deprecate yo-yoify

Fixes #33

@goto-bus-stop
Copy link
Copy Markdown
Member

goto-bus-stop commented Mar 9, 2018

re the license change choojs/choo#582 (comment)

@yoshuawuyts
Copy link
Copy Markdown
Member Author

yoshuawuyts commented Mar 11, 2018

Reverted to MIT

@yoshuawuyts
Copy link
Copy Markdown
Member Author

yoshuawuyts commented Mar 11, 2018

Ported benchmarks. Depends on mafintosh/nanobench#7 to be merged, but it shouldn't hold up merging this I reckon. Thanks!

ghost
ghost reviewed Mar 12, 2018
View reviewed changes
Comment thread README.md
### Browserify
```sh
$ browserify -t nanohtml index.js > bundle.js
```
Copy link
Copy Markdown

@ghost ghost Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAYBE add a code example here too

Comment thread package.json Outdated
"main": "index.js",
"browser": "browser.js",
"name": "nanohtml",
"description": "HTML template strings renderer for Node & Browsers.",
Copy link
Copy Markdown

@ghost ghost Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HTML template string renderer for the browser & Node

i think we should display preference towards the browser here

Comment thread types/index.d.ts Outdated
@@ -0,0 +1,4 @@
declare module "bel" {
Copy link
Copy Markdown

@ghost ghost Mar 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be changed?

@yoshuawuyts
Copy link
Copy Markdown
Member Author

yoshuawuyts commented Mar 12, 2018

@oe updated with all feedback!

@yoshuawuyts yoshuawuyts merged commit 6c75e5a into master Mar 12, 2018
@goto-bus-stop goto-bus-stop deleted the nanohtml branch March 13, 2018 11:18
@tunnckoCore
Copy link
Copy Markdown

tunnckoCore commented Mar 14, 2018

Damn.. Is bel 6 same as this? Why not just created nanohtml and let bel as it was on latest v5? Now updating services may update to v6 - it won't be a problem cuz is drop in replacement, but will pull more dependencies... Another way is to ignore the v6 update. ;/ Really sad. Bel worked both sides anyway.

@goto-bus-stop
Copy link
Copy Markdown
Member

goto-bus-stop commented Mar 14, 2018 via email

@tunnckoCore
Copy link
Copy Markdown

tunnckoCore commented Mar 14, 2018

That would be good if so.

@yoshuawuyts
Copy link
Copy Markdown
Member Author

yoshuawuyts commented Mar 14, 2018

@olstenlarck yep, @goto-bus-stop is right - that's exactly what we did. Most so if people perform a fresh bel install, they'll be nudged to move to nanohtml instead. Non-intrusive deprecations 🎉

@bcomnes bcomnes mentioned this pull request Mar 22, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshuawuyts @goto-bus-stop @tunnckoCore